[llvm] [SDAG] Bad codegen for swapping two bits (PR #205315)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 23 03:45:27 PDT 2026
https://github.com/sreedivyakottilingal created https://github.com/llvm/llvm-project/pull/205315
Fixes #110402
Fix by counting how many live bits actually changed position. A pattern where 2 or fewer bits moved is treated as a degenerate swap rather than a true bitreverse, and is left in its original form. Verified via BitProvenance traces that genuine bitreverse idioms move far more than 2 bits, so existing recognition is unaffected.
Alive2 : https://alive2.llvm.org/ce/z/IEZhbq
>From e20654ec2594bf6c0328ed562972a7f33ed0ef2c Mon Sep 17 00:00:00 2001
From: Sreedivya K <sreedivya.k at multicorewareinc.com>
Date: Tue, 23 Jun 2026 12:38:10 +0530
Subject: [PATCH 1/2] Added test cases for Bad codegen for swapping two bit
---
llvm/test/Transforms/InstCombine/bitreverse.ll | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/llvm/test/Transforms/InstCombine/bitreverse.ll b/llvm/test/Transforms/InstCombine/bitreverse.ll
index 2d303efbe66c8..5464cf4293de5 100644
--- a/llvm/test/Transforms/InstCombine/bitreverse.ll
+++ b/llvm/test/Transforms/InstCombine/bitreverse.ll
@@ -534,3 +534,18 @@ define i64 @rev_all_operand64_multiuse_both(i64 %a, i64 %b) #0 {
}
declare i32 @llvm.bswap.i32(i32 %or11.i)
+
+
+define i16 @bit_swap(i16 %v3) {
+; CHECK-LABEL: @bit_swap(
+; CHECK-NEXT: [[TMP1:%.*]] = and i16 [[V3:%.*]], -32767
+; CHECK-NEXT: [[OR:%.*]] = call i16 @llvm.bitreverse.i16(i16 [[TMP1]])
+; CHECK-NEXT: ret i16 [[OR]]
+;
+ %conv = zext i16 %v3 to i32
+ %shl = shl i32 %conv, 15
+ %shr = ashr i32 %conv, 15
+ %or = or i32 %shl, %shr
+ %conv2 = trunc i32 %or to i16
+ ret i16 %conv2
+}
>From 90bb9ea821edf650712ea3e05e73f884dc528a71 Mon Sep 17 00:00:00 2001
From: Sreedivya K <sreedivya.k at multicorewareinc.com>
Date: Tue, 23 Jun 2026 15:07:14 +0530
Subject: [PATCH 2/2] Don't recognize bitreverse for single bit-pair swaps
(#110402)
Fix by counting how many live bits actually changed position. A
pattern where 2 or fewer bits moved is treated as a degenerate swap
rather than a true bitreverse, and is left in its original form.
Verified via BitProvenance traces that genuine bitreverse idioms move
far more than 2 bits, so existing recognition is unaffected.
Fixes #110402
---
llvm/lib/Transforms/Utils/Local.cpp | 15 +++++++++++++++
llvm/test/Transforms/InstCombine/bitreverse.ll | 5 +++--
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp
index 1e1c3ac56d9c1..bea1510bb8d4c 100644
--- a/llvm/lib/Transforms/Utils/Local.cpp
+++ b/llvm/lib/Transforms/Utils/Local.cpp
@@ -3805,6 +3805,21 @@ bool llvm::recognizeBSwapOrBitReverseIdiom(
assert(all_of(BitProvenance,
[](int8_t I) { return I == BitPart::Unset || 0 <= I; }) &&
"Illegal bit provenance index");
+ // Guard against misclassifying a degenerate bit-pair swap
+ // as a genuine bitreverse
+ unsigned MovedBits = 0;
+ unsigned TotalLiveBits = 0;
+ for (unsigned i = 0; i < BitProvenance.size(); ++i) {
+ int8_t Src = BitProvenance[i];
+ if (Src == BitPart::Unset)
+ continue;
+ TotalLiveBits++;
+ if (Src != (int8_t)i)
+ MovedBits++;
+ }
+ // Block if fewer than 4 bits moved (catches single bit-pair swaps)
+ if (TotalLiveBits > 0 && MovedBits <= 2)
+ return false;
// If the upper bits are zero, then attempt to perform as a truncated op.
Type *DemandedTy = ITy;
diff --git a/llvm/test/Transforms/InstCombine/bitreverse.ll b/llvm/test/Transforms/InstCombine/bitreverse.ll
index 5464cf4293de5..0ea4f2a42feb0 100644
--- a/llvm/test/Transforms/InstCombine/bitreverse.ll
+++ b/llvm/test/Transforms/InstCombine/bitreverse.ll
@@ -538,8 +538,9 @@ declare i32 @llvm.bswap.i32(i32 %or11.i)
define i16 @bit_swap(i16 %v3) {
; CHECK-LABEL: @bit_swap(
-; CHECK-NEXT: [[TMP1:%.*]] = and i16 [[V3:%.*]], -32767
-; CHECK-NEXT: [[OR:%.*]] = call i16 @llvm.bitreverse.i16(i16 [[TMP1]])
+; CHECK-NEXT: [[SHL:%.*]] = shl i16 [[V3:%.*]], 15
+; CHECK-NEXT: [[SHR:%.*]] = lshr i16 [[V3]], 15
+; CHECK-NEXT: [[OR:%.*]] = or disjoint i16 [[SHL]], [[SHR]]
; CHECK-NEXT: ret i16 [[OR]]
;
%conv = zext i16 %v3 to i32
More information about the llvm-commits
mailing list