[llvm] [AMDGPU] Remove stale declarations. NFC. (PR #205047)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 22 00:47:03 PDT 2026
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/205047
Remove declarations of functions that are never defined. Also remove
unused field AMDGPUInstructionSelector::TM.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply at anthropic.com>
>From ac67b865cd15634bfa5f83d7d4c572aa11bba071 Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Mon, 22 Jun 2026 08:42:32 +0100
Subject: [PATCH] [AMDGPU] Remove stale declarations. NFC.
Remove declarations of functions that are never defined. Also remove
unused field AMDGPUInstructionSelector::TM.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply at anthropic.com>
---
llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h | 5 -----
.../AMDGPU/AMDGPUInstructionSelector.cpp | 6 ++----
.../Target/AMDGPU/AMDGPUInstructionSelector.h | 6 +-----
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h | 2 --
llvm/lib/Target/AMDGPU/GCNSubtarget.cpp | 2 +-
llvm/lib/Target/AMDGPU/R600ISelLowering.h | 2 --
llvm/lib/Target/AMDGPU/SIMachineScheduler.h | 1 -
llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h | 21 -------------------
8 files changed, 4 insertions(+), 41 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
index 34e461d19518e..95f85a6151375 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
@@ -216,8 +216,6 @@ class AMDGPUDAGToDAGISel : public SelectionDAGISel {
bool SelectSMRDBufferImm32(SDValue N, SDValue &Offset) const;
bool SelectSMRDBufferSgprImm(SDValue N, SDValue &SOffset,
SDValue &Offset) const;
- bool SelectSMRDPrefetchImm(SDValue Addr, SDValue &SBase,
- SDValue &Offset) const;
bool SelectMOVRELOffset(SDValue Index, SDValue &Base, SDValue &Offset) const;
bool SelectVOP3ModsImpl(SDValue In, SDValue &Src, unsigned &SrcMods,
@@ -232,8 +230,6 @@ class AMDGPUDAGToDAGISel : public SelectionDAGISel {
SDValue &Clamp, SDValue &Omod) const;
bool SelectVOP3BMods0(SDValue In, SDValue &Src, SDValue &SrcMods,
SDValue &Clamp, SDValue &Omod) const;
- bool SelectVOP3NoMods0(SDValue In, SDValue &Src, SDValue &SrcMods,
- SDValue &Clamp, SDValue &Omod) const;
bool SelectVINTERPModsImpl(SDValue In, SDValue &Src, SDValue &SrcMods,
bool OpSel) const;
@@ -298,7 +294,6 @@ class AMDGPUDAGToDAGISel : public SelectionDAGISel {
void SelectS_BFE(SDNode *N);
bool isCBranchSCC(const SDNode *N) const;
void SelectBRCOND(SDNode *N);
- void SelectFMAD_FMA(SDNode *N);
void SelectFP_EXTEND(SDNode *N);
void SelectDSAppendConsume(SDNode *N, unsigned IntrID);
void SelectDSBvhStackIntrinsic(SDNode *N, unsigned IntrID);
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
index 8086d5a69bb1c..c85d7124f62bb 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
@@ -41,10 +41,8 @@ using namespace MIPatternMatch;
#undef AMDGPUSubtarget
AMDGPUInstructionSelector::AMDGPUInstructionSelector(
- const GCNSubtarget &STI, const AMDGPURegisterBankInfo &RBI,
- const AMDGPUTargetMachine &TM)
- : TII(*STI.getInstrInfo()), TRI(*STI.getRegisterInfo()), RBI(RBI), TM(TM),
- STI(STI),
+ const GCNSubtarget &STI, const AMDGPURegisterBankInfo &RBI)
+ : TII(*STI.getInstrInfo()), TRI(*STI.getRegisterInfo()), RBI(RBI), STI(STI),
#define GET_GLOBALISEL_PREDICATES_INIT
#include "AMDGPUGenGlobalISel.inc"
#undef GET_GLOBALISEL_PREDICATES_INIT
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
index 6f242d0173531..1b6722f357080 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
@@ -52,8 +52,7 @@ class AMDGPUInstructionSelector final : public InstructionSelector {
public:
AMDGPUInstructionSelector(const GCNSubtarget &STI,
- const AMDGPURegisterBankInfo &RBI,
- const AMDGPUTargetMachine &TM);
+ const AMDGPURegisterBankInfo &RBI);
bool select(MachineInstr &I) override;
static const char *getName();
@@ -101,7 +100,6 @@ class AMDGPUInstructionSelector final : public InstructionSelector {
bool selectG_UADDO_USUBO_UADDE_USUBE(MachineInstr &I) const;
bool selectG_AMDGPU_MAD_64_32(MachineInstr &I) const;
bool selectG_EXTRACT(MachineInstr &I) const;
- bool selectG_FMA_FMAD(MachineInstr &I) const;
bool selectS16MergeToS32(MachineInstr &MI) const;
bool selectG_MERGE_VALUES(MachineInstr &I) const;
bool selectG_UNMERGE_VALUES(MachineInstr &I) const;
@@ -157,7 +155,6 @@ class AMDGPUInstructionSelector final : public InstructionSelector {
bool selectNamedBarrierInst(MachineInstr &I, Intrinsic::ID IID) const;
bool selectSBarrierSignalIsfirst(MachineInstr &I, Intrinsic::ID IID) const;
bool selectSGetBarrierState(MachineInstr &I, Intrinsic::ID IID) const;
- bool selectSBarrierLeave(MachineInstr &I) const;
bool selectWaveShuffleIntrin(MachineInstr &I) const;
std::pair<Register, unsigned> selectVOP3ModsImpl(Register Src,
@@ -466,7 +463,6 @@ class AMDGPUInstructionSelector final : public InstructionSelector {
const SIInstrInfo &TII;
const SIRegisterInfo &TRI;
const AMDGPURegisterBankInfo &RBI;
- const AMDGPUTargetMachine &TM;
const GCNSubtarget &STI;
#define GET_GLOBALISEL_PREDICATES_DECL
#define AMDGPUSubtarget GCNSubtarget
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
index 53cd6d786ee2f..89819fe990f5a 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
@@ -231,8 +231,6 @@ class AMDGPULegalizerInfo final : public LegalizerInfo {
bool legalizeLaneOp(LegalizerHelper &Helper, MachineInstr &MI,
Intrinsic::ID IID) const;
- bool legalizeBVHIntrinsic(MachineInstr &MI, MachineIRBuilder &B) const;
-
bool legalizeStackSave(MachineInstr &MI, MachineIRBuilder &B) const;
bool legalizeWaveID(MachineInstr &MI, MachineIRBuilder &B) const;
bool legalizeConstHwRegRead(MachineInstr &MI, MachineIRBuilder &B,
diff --git a/llvm/lib/Target/AMDGPU/GCNSubtarget.cpp b/llvm/lib/Target/AMDGPU/GCNSubtarget.cpp
index 55edfc2ea52d2..1ec3e45cc0359 100644
--- a/llvm/lib/Target/AMDGPU/GCNSubtarget.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNSubtarget.cpp
@@ -201,7 +201,7 @@ GCNSubtarget::GCNSubtarget(const Triple &TT, StringRef GPU, StringRef FS,
Legalizer = std::make_unique<AMDGPULegalizerInfo>(*this, TM);
RegBankInfo = std::make_unique<AMDGPURegisterBankInfo>(*this);
InstSelector =
- std::make_unique<AMDGPUInstructionSelector>(*this, *RegBankInfo, TM);
+ std::make_unique<AMDGPUInstructionSelector>(*this, *RegBankInfo);
}
const SelectionDAGTargetInfo *GCNSubtarget::getSelectionDAGInfo() const {
diff --git a/llvm/lib/Target/AMDGPU/R600ISelLowering.h b/llvm/lib/Target/AMDGPU/R600ISelLowering.h
index e70b78de6bf15..b3056018c3208 100644
--- a/llvm/lib/Target/AMDGPU/R600ISelLowering.h
+++ b/llvm/lib/Target/AMDGPU/R600ISelLowering.h
@@ -73,8 +73,6 @@ class R600TargetLowering final : public AMDGPUTargetLowering {
SDValue LowerImplicitParameter(SelectionDAG &DAG, EVT VT, const SDLoc &DL,
unsigned DwordOffset) const;
- void lowerImplicitParameter(MachineInstr *MI, MachineBasicBlock &BB,
- MachineRegisterInfo & MRI, unsigned dword_offset) const;
SDValue OptimizeSwizzle(SDValue BuildVector, SDValue Swz[],
SelectionDAG &DAG, const SDLoc &DL) const;
SDValue vectorToVerticalVector(SelectionDAG &DAG, SDValue Vector) const;
diff --git a/llvm/lib/Target/AMDGPU/SIMachineScheduler.h b/llvm/lib/Target/AMDGPU/SIMachineScheduler.h
index 1245774400af1..70b50b486f677 100644
--- a/llvm/lib/Target/AMDGPU/SIMachineScheduler.h
+++ b/llvm/lib/Target/AMDGPU/SIMachineScheduler.h
@@ -200,7 +200,6 @@ class SIScheduleBlock {
void nodeScheduled(SUnit *SU);
void tryCandidateTopDown(SISchedCandidate &Cand, SISchedCandidate &TryCand);
- void tryCandidateBottomUp(SISchedCandidate &Cand, SISchedCandidate &TryCand);
SUnit* pickNode();
void traceCandidate(const SISchedCandidate &Cand);
void initRegPressure(MachineBasicBlock::iterator BeginBlock,
diff --git a/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h b/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
index 6c771b3460662..93bc40807399e 100644
--- a/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
+++ b/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
@@ -1031,12 +1031,6 @@ bool isTrue16Inst(unsigned Opc);
LLVM_READONLY
FPType getFPDstSelType(unsigned Opc);
-LLVM_READONLY
-bool isInvalidSingleUseConsumerInst(unsigned Opc);
-
-LLVM_READONLY
-bool isInvalidSingleUseProducerInst(unsigned Opc);
-
bool isDPMACCInstruction(unsigned Opc);
LLVM_READONLY
@@ -1069,14 +1063,6 @@ std::tuple<char, unsigned, unsigned> parseAsmPhysRegName(StringRef TupleString);
std::tuple<char, unsigned, unsigned>
parseAsmConstraintPhysReg(StringRef Constraint);
-/// \returns Integer value requested using \p F's \p Name attribute.
-///
-/// \returns \p Default if attribute is not present.
-///
-/// \returns \p Default and emits error if requested value cannot be converted
-/// to integer.
-int getIntegerAttribute(const Function &F, StringRef Name, int Default);
-
/// \returns A pair of integer values requested using \p F's \p Name attribute
/// in "first[,second]" format ("second" is optional unless \p OnlyFirstRequired
/// is false).
@@ -1443,8 +1429,6 @@ bool getHasColorExport(const Function &F);
bool getHasDepthExport(const Function &F);
-bool hasDynamicVGPR(const Function &F);
-
// Returns the value of the "amdgpu-dynamic-vgpr-block-size" attribute, or 0 if
// the attribute is missing or its value is invalid.
unsigned getDynamicVGPRBlockSize(const Function &F);
@@ -1809,11 +1793,6 @@ std::optional<int64_t> getSMRDEncodedLiteralOffset32(const MCSubtargetInfo &ST,
/// offsets.
unsigned getNumFlatOffsetBits(const MCSubtargetInfo &ST);
-/// \returns true if this offset is small enough to fit in the SMRD
-/// offset field. \p ByteOffset should be the offset in bytes and
-/// not the encoded offset.
-bool isLegalSMRDImmOffset(const MCSubtargetInfo &ST, int64_t ByteOffset);
-
LLVM_READNONE
inline bool isLegalDPALU_DPPControl(const MCSubtargetInfo &ST, unsigned DC) {
if (isGFX12(ST))
More information about the llvm-commits
mailing list