[llvm] [SelectionDAG] Fix isKnownNeverNaN OR-logic for FMINNUM/FMAXNUM with SNaN (PR #204736)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 19 02:01:07 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index c9369a2d7..5f7ed399c 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -6432,7 +6432,8 @@ bool SelectionDAG::isKnownNeverNaN(SDValue Op, const APInt &DemandedElts,
if (!SNaN)
// The result is a NaN only if both operands are NaN, so it is never NaN
// if either operand is known to never be NaN.
- return isKnownNeverNaN(Op.getOperand(0), DemandedElts, false, Depth + 1) ||
+ return isKnownNeverNaN(Op.getOperand(0), DemandedElts, false,
+ Depth + 1) ||
isKnownNeverNaN(Op.getOperand(1), DemandedElts, false, Depth + 1);
// These do not quiet a signaling NaN: if either operand may be a signaling
// NaN it can be returned unchanged, so both operands must be known to never
``````````
</details>
https://github.com/llvm/llvm-project/pull/204736
More information about the llvm-commits
mailing list