[llvm] Reapply "[lit] Deprecate execute_external=True in ShTest" (#203316) (PR #203689)

Sudharsan Veeravalli via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 01:23:28 PDT 2026


================
@@ -17,8 +17,19 @@ class ShTest(FileBasedTest):
     """
 
     def __init__(
-        self, execute_external=False, extra_substitutions=[], preamble_commands=[]
+        self,
+        execute_external=False,
+        extra_substitutions=[],
+        preamble_commands=[],
+        force_execute_external=False,
     ):
+        if execute_external and not force_execute_external:
+            raise ValueError(
+                "execute_external=True is deprected as of LLVM-23 and the option will "
----------------
svs-quic wrote:

Absolute NIT but this needs to be `deprecated`

https://github.com/llvm/llvm-project/pull/203689


More information about the llvm-commits mailing list