[llvm] [AMDGPU] NFC: Obviously show isVALU includes LDSDMA instructions (PR #203548)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 12 09:19:55 PDT 2026
================
@@ -646,12 +652,13 @@ class SIInstrInfo final : public AMDGPUGenInstrInfo {
}
static bool isLDSDMA(const MachineInstr &MI) {
- return (isVALU(MI) && (isMUBUF(MI) || isFLAT(MI))) ||
+ return (isVALU(MI, /*AllowLDSDMA=*/true) && (isMUBUF(MI) || isFLAT(MI))) ||
----------------
jayfoad wrote:
I don't really like the way this makes isVALU and isLDSDMA mutually recursive. Maybe just expand the `MI.getDesc().TSFlags & SIInstrFlags::VALU` part here instead of calling isVALU? Same below.
https://github.com/llvm/llvm-project/pull/203548
More information about the llvm-commits
mailing list