[compiler-rt] [Fuzzer] Use the internal shell by default (PR #203450)

[via llvm-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Aiden Grossman (boomanaiden154)

<details>
<summary>Changes</summary>

The external shell is going away soon and the internal shell is superior in most ways (platform compatibility, performance, debugging). This now causes no test failures and is blocking deprecation of the external shell, so switch over.

---
Full diff: https://github.com/llvm/llvm-project/pull/203450.diff


1 Files Affected:

- (modified) compiler-rt/test/fuzzer/lit.cfg.py (+1-13) 


``````````diff
diff --git a/compiler-rt/test/fuzzer/lit.cfg.py b/compiler-rt/test/fuzzer/lit.cfg.py
index 8cb731af24314..73195289f021c 100644
--- a/compiler-rt/test/fuzzer/lit.cfg.py
+++ b/compiler-rt/test/fuzzer/lit.cfg.py
@@ -3,27 +3,15 @@
 import os
 
 config.name = "libFuzzer" + config.name_suffix
-config.test_format = lit.formats.ShTest(True)
 config.suffixes = [".test"]
 config.test_source_root = os.path.dirname(__file__)
 config.available_features.add(config.target_arch)
 
-# Choose between lit's internal shell pipeline runner and a real shell.  If
-# LIT_USE_INTERNAL_SHELL is in the environment, we use that as an override.
-use_lit_shell = os.environ.get("LIT_USE_INTERNAL_SHELL")
-if use_lit_shell:
-    # 0 is external, "" is default, and everything else is internal.
-    execute_external = use_lit_shell == "0"
-else:
-    # Otherwise we default to internal on Windows and external elsewhere, as
-    # bash on Windows is usually very slow.
-    execute_external = not sys.platform in ["win32"]
-
 # testFormat: The test format to use to interpret tests.
 #
 # For now we require '&&' between commands, until they get globally killed and
 # the test runner updated.
-config.test_format = lit.formats.ShTest(execute_external)
+config.test_format = lit.formats.ShTest()
 
 # LeakSanitizer is not supported on OSX or Windows right now.
 if (

``````````

</details>


https://github.com/llvm/llvm-project/pull/203450