[llvm] [X86] Disallow immediate address calls when position independent (PR #202370)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 08:58:07 PDT 2026


https://github.com/agrieve updated https://github.com/llvm/llvm-project/pull/202370

>From 3ce4a6130faa8782956fb9630de4a79fe7e4e5f2 Mon Sep 17 00:00:00 2001
From: Andrew Grieve <agrieve at chromium.org>
Date: Mon, 8 Jun 2026 11:42:27 -0400
Subject: [PATCH] [X86] Disallow immediate address calls when position
 independent

---
 llvm/lib/Target/X86/X86Subtarget.cpp | 2 +-
 llvm/test/CodeGen/X86/call-imm.ll    | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/llvm/lib/Target/X86/X86Subtarget.cpp b/llvm/lib/Target/X86/X86Subtarget.cpp
index c576ba9e45506..5dbcb3ae2939b 100644
--- a/llvm/lib/Target/X86/X86Subtarget.cpp
+++ b/llvm/lib/Target/X86/X86Subtarget.cpp
@@ -241,7 +241,7 @@ bool X86Subtarget::isLegalToCallImmediateAddr() const {
   // FIXME: I386 PE/COFF supports PC relative calls using IMAGE_REL_I386_REL32
   // but WinCOFFObjectWriter::RecordRelocation cannot emit them.  Once it does,
   // the following check for Win32 should be removed.
-  if (Is64Bit || isTargetWin32())
+  if (Is64Bit || isTargetWin32() || isPositionIndependent())
     return false;
   return isTargetELF() || TM.getRelocationModel() == Reloc::Static;
 }
diff --git a/llvm/test/CodeGen/X86/call-imm.ll b/llvm/test/CodeGen/X86/call-imm.ll
index b8f5a0cb9b428..39b61c37480a3 100644
--- a/llvm/test/CodeGen/X86/call-imm.ll
+++ b/llvm/test/CodeGen/X86/call-imm.ll
@@ -1,6 +1,7 @@
 ; RUN: llc < %s -mtriple=i386-apple-darwin -relocation-model=static | FileCheck -check-prefix X86STA %s
 ; RUN: llc < %s -mtriple=i386-apple-darwin -relocation-model=pic | FileCheck -check-prefix X86PIC %s
 ; RUN: llc < %s -mtriple=i386-pc-linux -relocation-model=dynamic-no-pic | FileCheck -check-prefix X86DYN %s
+; RUN: llc < %s -mtriple=i386-pc-linux -relocation-model=pic | FileCheck -check-prefix X86ELFPIC %s
 ; RUN: llc < %s -mtriple=i386-pc-win32 -relocation-model=static | FileCheck -check-prefix X86WINSTA %s
 
 ; Call to immediate is not safe on x86-64 unless we *know* that the
@@ -21,5 +22,6 @@ entry:
 ; X86STA: {{call.*12345678}}
 ; X86PIC-NOT: {{call.*12345678}}
 ; X86DYN: {{call.*12345678}}
+; X86ELFPIC: {{call.*[*]%eax}}
 ; X86WINSTA: {{call.*[*]%eax}}
 ; X64: {{call.*[*]%rax}}



More information about the llvm-commits mailing list