[lld] [llvm] [Support][LLD] .time-trace.json Default File Extension (PR #122207)

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 00:13:49 PDT 2026


================
@@ -84,6 +84,8 @@ namespace llvm {
 
 class raw_pwrite_stream;
 
+static constexpr const auto TimeTraceFileExtension = ".time-trace.json";
----------------
zmodem wrote:

If we're not going to use it outside the .cpp file, I think it's better to move it there.

About the type, my point was mostly that I think we should spell it out rather than using auto, and that either of const or constexpr should be enough -- having both seems redundant.

https://github.com/llvm/llvm-project/pull/122207


More information about the llvm-commits mailing list