[llvm] [OFFLOAD][L0] Use counter-based events for inorder queues (PR #202301)
Nick Sarnie via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 11 07:57:08 PDT 2026
================
@@ -33,9 +33,10 @@ class L0EventTy {
ze_event_handle_t getZeEvent() const { return ZeEvent; }
L0QueueTy *getQueue() const { return Queue; }
- Error reset() {
+ Error reset(bool SkipEventReset) {
----------------
sarnex wrote:
dumb question maybe, but fundamentally what is an event reset? Since `Queue` is just a normal pointer, setting it to `nullptr` seems to just be for bookkeeping in this class and doesn't have any other semantics (like calling the dtor if were a smart ptr)
i'm asking because i wonder if it makes sense to keep the `reset` function always calling `zeEventHostReset`, but then have a new function `clearQueue` or something that only does `Queue = nullptr`, and that new function is called both by `rest` and by whatever callsite doesnt want the `zeEventHostReset` call
https://github.com/llvm/llvm-project/pull/202301
More information about the llvm-commits
mailing list