[compiler-rt] [asan] Fix asan_new_delete.cpp C++ header resolution under -nostdinc++ (PR #202816)
Justin T. Gibbs via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 10 07:52:30 PDT 2026
scsiguy wrote:
> @scsiguy Since you already have this fix-forward ready, I've requested the reviews. But for future reference: "we tend to make much heavier use of reverts to keep the tree healthy than some other open source projects, and our norms are a bit different …
@thurstond, thanks for the feedback. I don’t think the guidance here is that different from other projects I’ve worked on (e.g. FreeBSD), and this was also my first inclination. However, the failure is in the CI of a downstream project (Fuscia) and a fix for their immediate issue had already been merged - preventing a clean revert - so fixing forward seemed the right approach. Should I have just reverted both commits?
https://github.com/llvm/llvm-project/pull/202816
More information about the llvm-commits
mailing list