[llvm] [SPIR-V] Fix division by zero on byte addressing GEP into a subbyte array (PR #202593)

[via llvm-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-spir-v

Author: Arseniy Obolenskiy (aobolensk)

<details>
<summary>Changes</summary>

walkLogicalAccessChainConstant divided the byte offset by the element size which is zero for sub-byte element types ([N x i1])

---
Full diff: https://github.com/llvm/llvm-project/pull/202593.diff


2 Files Affected:

- (modified) llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp (+4-1) 
- (added) llvm/test/CodeGen/SPIRV/pointers/getelementptr-subbyte-array.ll (+19) 


``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
index 180084a65d5b0..1bb85dea2a546 100644
--- a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
@@ -790,7 +790,10 @@ bool SPIRVEmitIntrinsics::walkLogicalAccessChainConstant(
 
   do {
     if (ArrayType *AT = dyn_cast<ArrayType>(CurType)) {
-      uint32_t EltTypeSize = DL.getTypeSizeInBits(AT->getElementType()) / 8;
+      TypeSize EltSizeBits = DL.getTypeSizeInBits(AT->getElementType());
+      if (EltSizeBits % 8 != 0)
+        return true;
+      uint32_t EltTypeSize = EltSizeBits / 8;
       assert(Offset < AT->getNumElements() * EltTypeSize);
       uint64_t Index = Offset / EltTypeSize;
       Offset = Offset - (Index * EltTypeSize);
diff --git a/llvm/test/CodeGen/SPIRV/pointers/getelementptr-subbyte-array.ll b/llvm/test/CodeGen/SPIRV/pointers/getelementptr-subbyte-array.ll
new file mode 100644
index 0000000000000..2d6e1504cc85c
--- /dev/null
+++ b/llvm/test/CodeGen/SPIRV/pointers/getelementptr-subbyte-array.ll
@@ -0,0 +1,19 @@
+; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+
+; CHECK-DAG: %[[#bool:]] = OpTypeBool
+; CHECK-DAG: %[[#int32:]] = OpTypeInt 32 0
+; CHECK-DAG: %[[#size:]] = OpConstant %[[#int32]] 8
+; CHECK-DAG: %[[#arr:]] = OpTypeArray %[[#bool]] %[[#size]]
+; CHECK-DAG: %[[#ptr:]] = OpTypePointer Function %[[#arr]]
+
+; CHECK: OpFunction
+; CHECK: OpVariable %[[#ptr]] Function
+
+ at global = internal global [8 x i1] zeroinitializer
+
+define void @foo() {
+entry:
+  %gep = getelementptr inbounds i8, ptr @global, i32 1
+  ret void
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/202593