[llvm] [DirectX] Delay converting to old-style debug info (PR #201336)
Harald van Dijk via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 08:38:14 PDT 2026
hvdijk wrote:
> LGTM but it's a bit awkward to leave the definition of getNonDXILAttributeMask in DXILPrepare.cpp - we don't really have a better place for it though. Do you think it's worth adding a new .cpp file just for this function?
I agree it's not ideal, but like you I also don't see a better place for it. My thinking at the moment it doesn't really do any harm, and until we get more utility functions, I won't know if this should be one general `DirectXUtils.cpp`, or something split up further. I'm thinking we're best off leaving it as it is for now.
https://github.com/llvm/llvm-project/pull/201336
More information about the llvm-commits
mailing list