[llvm] [llvm-objdump] Add --substitute-path and --source-dir for --source (PR #201096)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 02:09:43 PDT 2026


https://github.com/jh7370 commented:

Please can you confirm you wrote your description following this guidance:

> To ensure sufficient self review and understanding of the work, it is strongly recommended that contributors write PR descriptions themselves (if needed, using tools for translation or copy-editing).

If you didn't, please delete the existing description and rewrite it entirely from scratch without LLM assistance (aside from the noted translation and copy-editing uses).

If you did write it by hand, please note that we don't usually include references to how the code was tested functionally (though notes about the performance testing you did would be welcome). This is because the commit description should be primarily about the why and little about the what, as we can see from the change itself the what, e.g. what tests have been added and modified.

Also, see this quote from the AI Policy:

> Contributors should note tool usage in their pull request description, commit message, or wherever authorship is normally indicated for the work. For instance, use a commit message trailer like Assisted-by:

The description does not conform to this, given you used an LLM.

Finally, please don't mark conversations that I have initiated as "resolved". I use the "resolved" button on such conversations to allow me to check that I am happy with the responses to comments I've previously raised.

Regarding the behaviour: how do you expect the new options to interact with `--prefix` and `--prefix-strip`? I think some testing of this interaction would be worthwhile, to show how these options interact.

https://github.com/llvm/llvm-project/pull/201096


More information about the llvm-commits mailing list