[llvm] [BOLT] Add pre-parsed perf script support (PR #163785)

[Ádám Kallai via llvm-commits]

================
@@ -7,6 +7,12 @@ set(LLVM_LINK_COMPONENTS
 add_bolt_unittest(ProfileTests
   DataAggregator.cpp
   PerfSpeEvents.cpp
+  PerfScripts.cpp
+
+  # FIXME CoreTests uses `llvm::detail::TakeError(llvm::Error)`, but linking
+  #       to LLVMTestingSupport introduces a transitive dependency on the
+  #       dynamic LLVM library when LLVM_LINK_LLVM_DYLIB is ON.
+  ${LLVM_MAIN_SRC_DIR}/lib/Testing/Support/Error.cpp
----------------
kaadam wrote:

Hi Nico, Thanks for your feeedback!
CoreTests target refers to the core unitests in Bolt (bolt/unittests/Core/CMakeLists.txt).

I understand your point of view, this fix is not ideal. I've followed an existing workaround from here:
https://github.com/llvm/llvm-project/blob/main/bolt/unittests/Core/CMakeLists.txt#L18

Fixing this underlying build system issue wasn't the main focus of this PR, but I'm completely open to discussing how we could clean this up properly.

https://github.com/llvm/llvm-project/pull/163785