[llvm] [llvm-objcopy] Add -o to install_name_tool (PR #189495)

[James Henderson via llvm-commits]

jh7370 wrote:

> > Sorry, but this shouldn't have been merged without review. A lack of response to a PR does not mean you can just land it without review. The correct thing to do, per LLVM policy, is to ping it once a week until a response is received. In this case, this fell off my review list due to some time off. A ping would have caused it to bump up again.
> 
> sorry, i'll be more patient next time. I merged this because I felt like it was trivial enough to qualify for post-merge review
> 
> > Specifically, once a patch is sent out for review, it needs an explicit approval before it is committed.
> 
> I believe the wording on this is a bit outdated since PRs are now always required? (maybe im jumping that decision being finalized)

Given that this was originally created as a PR on the 30th March, but not merged until a lot later, it sounds to me like you were originally looking for pre-commit review. My understanding from this doc, in particular the note below, is that you make the decision to seek pre-commit or post-commit review at the time of creation and add the "skip-precommit-approval" label if the latter is preferred. Once seeking pre-commit approval, you can't subsequently change your mind. Note that the use of PRs is required, but obtaining a pre-commit review is not.

https://github.com/llvm/llvm-project/pull/189495