[llvm] [JumpThreading] NFC: Add comment referencing #199408. (PR #199718)
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 5 05:03:30 PDT 2026
================
@@ -2789,6 +2789,13 @@ void JumpThreadingPass::unfoldSelectInstr(BasicBlock *Pred, BasicBlock *BB,
PredTerm->removeFromParent();
PredTerm->insertInto(NewBB, NewBB->end());
// Create a conditional branch and update PHI nodes.
+ //
+ // Note: Technically we should `freeze` the condition before using it in a
+ // conditional branch, unless we can prove it's not poison: select-on-on
----------------
jlebar wrote:
Fixed, ty
https://github.com/llvm/llvm-project/pull/199718
More information about the llvm-commits
mailing list