[lld] [lld-macho] Sort LC_LINKER_OPTIONS before processing (PR #201604)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 4 07:54:14 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- lld/MachO/Driver.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/lld/MachO/Driver.cpp b/lld/MachO/Driver.cpp
index 9142301ed..ef24a79a7 100644
--- a/lld/MachO/Driver.cpp
+++ b/lld/MachO/Driver.cpp
@@ -726,19 +726,21 @@ void macho::resolveLCLinkerOptions() {
llvm::sort(frameworks);
llvm::sort(libraries);
- frameworks.erase(std::unique(frameworks.begin(), frameworks.end()), frameworks.end());
- libraries.erase(std::unique(libraries.begin(), libraries.end()), libraries.end());
+ frameworks.erase(std::unique(frameworks.begin(), frameworks.end()),
+ frameworks.end());
+ libraries.erase(std::unique(libraries.begin(), libraries.end()),
+ libraries.end());
for (const StringRef framework : frameworks) {
- addFramework(framework, /*isNeeded=*/false, /*isWeak=*/false,
- /*isReexport=*/false, /*isExplicit=*/false,
- LoadType::LCLinkerOption, deferred);
+ addFramework(framework, /*isNeeded=*/false, /*isWeak=*/false,
+ /*isReexport=*/false, /*isExplicit=*/false,
+ LoadType::LCLinkerOption, deferred);
}
for (const StringRef library : libraries) {
- addLibrary(library, /*isNeeded=*/false, /*isWeak=*/false,
- /*isReexport=*/false, /*isHidden=*/false,
- /*isExplicit=*/false, LoadType::LCLinkerOption, deferred);
+ addLibrary(library, /*isNeeded=*/false, /*isWeak=*/false,
+ /*isReexport=*/false, /*isHidden=*/false,
+ /*isExplicit=*/false, LoadType::LCLinkerOption, deferred);
}
for (auto &file : deferred) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/201604
More information about the llvm-commits
mailing list