[llvm] 6a68bd8 - [AMDGPU][GIsel] Replace old C type castings with safer C++ (#201505)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 4 04:15:05 PDT 2026
Author: adeshcom14
Date: 2026-06-04T16:45:00+05:30
New Revision: 6a68bd8892d9bbfaba3847fb48da78a8923fe144
URL: https://github.com/llvm/llvm-project/commit/6a68bd8892d9bbfaba3847fb48da78a8923fe144
DIFF: https://github.com/llvm/llvm-project/commit/6a68bd8892d9bbfaba3847fb48da78a8923fe144.diff
LOG: [AMDGPU][GIsel] Replace old C type castings with safer C++ (#201505)
AMDGPURegisterBankInfo.cpp still contains the old C style castings to int type which can be switched to much safer C++ variants.
Added:
Modified:
llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
index b7a4c6c9bd9ec..cc1f2d0664484 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
@@ -1282,7 +1282,7 @@ unsigned AMDGPURegisterBankInfo::setBufferOffsets(
/*CheckNUW=*/CheckNUW);
uint32_t SOffset, ImmOffset;
- if ((int)Offset > 0 &&
+ if (static_cast<int32_t>(Offset) > 0 &&
TII->splitMUBUFOffset(Offset, SOffset, ImmOffset, Alignment)) {
if (getRegBank(Base, *MRI, *TRI) == &AMDGPU::VGPRRegBank) {
VOffsetReg = Base;
@@ -1304,7 +1304,7 @@ unsigned AMDGPURegisterBankInfo::setBufferOffsets(
// Handle the variable sgpr + vgpr case.
MachineInstr *Add = getOpcodeDef(AMDGPU::G_ADD, CombinedOffset, *MRI);
- if (Add && (int)Offset >= 0 &&
+ if (Add && static_cast<int32_t>(Offset) >= 0 &&
(!CheckNUW || Add->getFlag(MachineInstr::NoUWrap))) {
Register Src0 = getSrcRegIgnoringCopies(Add->getOperand(1).getReg(), *MRI);
Register Src1 = getSrcRegIgnoringCopies(Add->getOperand(2).getReg(), *MRI);
@@ -1845,7 +1845,7 @@ AMDGPURegisterBankInfo::splitBufferOffsets(MachineIRBuilder &B,
// vgpr, even if adding the immediate offset makes it positive.
unsigned Overflow = ImmOffset & ~MaxImm;
ImmOffset -= Overflow;
- if ((int32_t)Overflow < 0) {
+ if (static_cast<int32_t>(Overflow) < 0) {
Overflow += ImmOffset;
ImmOffset = 0;
}
More information about the llvm-commits
mailing list