[llvm] [llvm-exegesis] Skip benchmark entries with unknown opcodes in analysis mode (PR #201162)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 2 10:54:08 PDT 2026
================
@@ -136,8 +136,12 @@ struct Benchmark {
static Expected<Benchmark> readYaml(const LLVMState &State,
MemoryBufferRef Buffer);
+ // Deserializes benchmarks from the given Buffer. If SkipInvalidEntries is
+ // true, entries that fail to parse (e.g. referencing an unknown opcode) are
+ // warned about and skipped instead of aborting the read of the whole file.
static Expected<std::vector<Benchmark>>
- readYamls(const LLVMState &State, MemoryBufferRef Buffer);
+ readYamls(const LLVMState &State, MemoryBufferRef Buffer,
----------------
boomanaiden154 wrote:
We should just skip invalid entries by default with a warning or maybe use a `cl::opt` in `BenchmarkResult.cpp`. I don't think there's a lot of value in parameterizing it here.
https://github.com/llvm/llvm-project/pull/201162
More information about the llvm-commits
mailing list