[llvm] [NVPTX] Respect FTZ flag when lowering atomicrmw fadd. (PR #200732)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 2 06:32:00 PDT 2026
================
@@ -7467,22 +7467,52 @@ NVPTXTargetLowering::AtomicExpansionKind
NVPTXTargetLowering::shouldExpandAtomicRMWInIR(const AtomicRMWInst *AI) const {
Type *Ty = AI->getValOperand()->getType();
- if (AI->isFloatingPointOperation()) {
- if (AI->getOperation() == AtomicRMWInst::BinOp::FAdd) {
- if (Ty->isHalfTy() && STI.getSmVersion() >= 70 &&
- STI.getPTXVersion() >= 63)
- return AtomicExpansionKind::None;
- if (Ty->isBFloatTy() && STI.getSmVersion() >= 90 &&
- STI.getPTXVersion() >= 78)
- return AtomicExpansionKind::None;
- if (Ty->isFloatTy())
- return AtomicExpansionKind::None;
- if (Ty->isDoubleTy() && STI.hasAtomAddF64())
- return AtomicExpansionKind::None;
+ // Try to lower LLVM atomicrmw fadd to PTX atomic.add. This is complicated
+ // by the weird FTZ behavior PTX atom.add has:
+ // - atom.add.f32 on global memory flushes denormals
+ // - atom.add.f32 on shared memory does not flush denormals
+ // - atom.add.f16 and atomic.add.bf16 never flush denormals
+ //
+ // We lower to atom.add only if the function's FTZ behavior matches that of
+ // atom.add; otherwise, we lower to a CAS loop. But we always allow
+ // atomic.add.bf16; even though it never flushes denormals, we never flush
----------------
gonzalobg wrote:
@akshayrdeodhar atom.add.bf16 should already not have been emitted, because we set the smallest atomic width supported to 32-bit, so that AtomicExpand always uses a cas-loop for anything smaller.
Was NVPTX accidentally opting out of that here for bf16 and float?
Or did this PR introduce the regression?
(if NVPTX already had this bug, I agree with justin that we should fix it in a separate PR; i just want to rule out a PR from introducing that regression)
https://github.com/llvm/llvm-project/pull/200732
More information about the llvm-commits
mailing list