[llvm] 3c86ffb - [LLVM][Verifier] Reject "splat (...)" as an invalid value for an immarg operand. (#200445)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 2 04:42:59 PDT 2026
Author: Paul Walker
Date: 2026-06-02T12:42:54+01:00
New Revision: 3c86ffb3bd282cfad0bf1e3aa2cedf1e4895b057
URL: https://github.com/llvm/llvm-project/commit/3c86ffb3bd282cfad0bf1e3aa2cedf1e4895b057
DIFF: https://github.com/llvm/llvm-project/commit/3c86ffb3bd282cfad0bf1e3aa2cedf1e4895b057.diff
LOG: [LLVM][Verifier] Reject "splat (...)" as an invalid value for an immarg operand. (#200445)
This makes the behaviour consistent with ConstantDataVector based
values.
Added:
Modified:
llvm/lib/IR/Verifier.cpp
llvm/test/Verifier/immarg-param-attribute-invalid.ll
Removed:
################################################################################
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 96f228f88a46c..c9639d1420bfc 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -4035,7 +4035,8 @@ void Verifier::visitCallBase(CallBase &Call) {
if (Call.paramHasAttr(i, Attribute::ImmArg)) {
Value *ArgVal = Call.getArgOperand(i);
- Check(isa<ConstantInt>(ArgVal) || isa<ConstantFP>(ArgVal),
+ Check((isa<ConstantInt>(ArgVal) || isa<ConstantFP>(ArgVal)) &&
+ !isa<VectorType>(ArgVal->getType()),
"immarg operand has non-immediate parameter", ArgVal, Call);
// If the imm-arg is an integer and also has a range attached,
diff --git a/llvm/test/Verifier/immarg-param-attribute-invalid.ll b/llvm/test/Verifier/immarg-param-attribute-invalid.ll
index 3975fe8cc0053..9df6fd7ffe67c 100644
--- a/llvm/test/Verifier/immarg-param-attribute-invalid.ll
+++ b/llvm/test/Verifier/immarg-param-attribute-invalid.ll
@@ -1,4 +1,5 @@
; RUN: not llvm-as < %s -o /dev/null 2>&1 | FileCheck %s
+; RUN: not llvm-as -use-constant-int-for-fixed-length-splat < %s -o /dev/null 2>&1 | FileCheck %s
declare void @llvm.test.immarg.intrinsic.i32(i32 immarg)
declare void @llvm.test.immarg.intrinsic.v2i32(<2 x i32> immarg)
@@ -45,6 +46,11 @@ define void @call_llvm.test.immarg.intrinsic.v2i32() {
; CHECK-NEXT: call void @llvm.test.immarg.intrinsic.v2i32(<2 x i32> <i32 1, i32 2>)
call void @llvm.test.immarg.intrinsic.v2i32(<2 x i32> <i32 1, i32 2>)
+; CHECK: immarg operand has non-immediate parameter
+; CHECK-NEXT: <2 x i32> splat (i32 1)
+; CHECK-NEXT: call void @llvm.test.immarg.intrinsic.v2i32(<2 x i32> splat (i32 1))
+ call void @llvm.test.immarg.intrinsic.v2i32(<2 x i32> splat (i32 1))
+
; CHECK: immarg operand has non-immediate parameter
; CHECK-NEXT: <2 x i32> undef
; CHECK-NEXT: call void @llvm.test.immarg.intrinsic.v2i32(<2 x i32> undef)
@@ -62,6 +68,11 @@ define void @call_llvm.test.immarg.intrinsic.v2f32() {
; CHECK-NEXT: <2 x float> <float 1.000000e+00, float 2.000000e+00>
; CHECK-NEXT: call void @llvm.test.immarg.intrinsic.v2f32(<2 x float> <float 1.000000e+00, float 2.000000e+00>)
call void @llvm.test.immarg.intrinsic.v2f32(<2 x float> <float 1.0, float 2.0>)
+
+; CHECK: immarg operand has non-immediate parameter
+; CHECK-NEXT: <2 x float> splat (float 1.000000e+00)
+; CHECK-NEXT: call void @llvm.test.immarg.intrinsic.v2f32(<2 x float> splat (float 1.000000e+00))
+ call void @llvm.test.immarg.intrinsic.v2f32(<2 x float> splat (float 1.0))
ret void
}
More information about the llvm-commits
mailing list