[llvm] [NFC][LLVM] Fix Intrinsics.td to adhere to 80 col limit (PR #199346)
Oliver Hunt via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 1 16:49:12 PDT 2026
ojhunt wrote:
> > Regarding git blame, it's already affected, so reverting won't fix this. But we should not do it again.
>
> Would adding this commit to https://github.com/llvm/llvm-project/blob/main/.git-blame-ignore-revs help?
I think reverting and then adding both might work? but I'm so far from a git expert it isn't even funny.
@jurahul as the links referred to demonstrate the non-formatting was intentional. Also just from an engineering PoV I don't understand the reason for such a change. I get that it benefitted you downstream, but I can make the same argument in reverse for us: we match the coding conventions of the files themselves downstream, not the global rules. There are endless files throughout the llvm repository that do not conform to the style rules, changing them solely for the purpose of (functionally) rewriting them in a different style literally carries nothing but cost.
IMO you made a significant change, without considering the repercussions, because it happened to benefit your downstream fork.
My opinion is that this should be reverted _if_ it is possible to do so in a way that restores git blame behavior - it think that is already going to make bisecting around here miserable, but that would be true for any change to the file so it's kind of moot and just annoying.
https://github.com/llvm/llvm-project/pull/199346
More information about the llvm-commits
mailing list