[llvm] [VPlan] Replace VPTypeAnalysis with VPValue::getScalarType. (NFC) (PR #200256)

[Luke Lau via llvm-commits]

================
@@ -1397,17 +1389,6 @@ static void simplifyRecipe(VPSingleDefRecipe *Def, VPTypeAnalysis &TypeInfo) {
         Def->replaceAllUsesWith(Trunc);
       }
     }
-#ifndef NDEBUG
-    // Verify that the cached type info is for both A and its users is still
-    // accurate by comparing it to freshly computed types.
-    VPTypeAnalysis TypeInfo2(*Plan);
-    assert(TypeInfo.inferScalarType(A) == TypeInfo2.inferScalarType(A));
-    for (VPUser *U : A->users()) {
-      auto *R = cast<VPRecipeBase>(U);
-      for (VPValue *VPV : R->definedValues())
-        assert(TypeInfo.inferScalarType(VPV) == TypeInfo2.inferScalarType(VPV));
-    }
-#endif
----------------
lukel97 wrote:

Great to see this footgun finally removed

https://github.com/llvm/llvm-project/pull/200256