[llvm] ef4e882 - Open yaml, etc as text files (#199253)
via llvm-commits
llvm-commits at lists.llvm.org
Fri May 22 12:32:26 PDT 2026
Author: Sean Perry
Date: 2026-05-22T19:32:20Z
New Revision: ef4e882c25a149041da5221ea765c0f3a2a7adb3
URL: https://github.com/llvm/llvm-project/commit/ef4e882c25a149041da5221ea765c0f3a2a7adb3
DIFF: https://github.com/llvm/llvm-project/commit/ef4e882c25a149041da5221ea765c0f3a2a7adb3.diff
LOG: Open yaml, etc as text files (#199253)
These tests were failing on z/OS because the text input files were being
opened as binary.
```
FAIL: LLVM :: tools/dsymutil/AArch64/typedef-different-types.test
FAIL: LLVM :: tools/dsymutil/X86/mismatch.m
FAIL: LLVM :: tools/dsymutil/embed-resource.test
FAIL: LLVM :: tools/llvm-gsymutil/X86/elf-symtab-file.yaml
```
Open the files as text to solve the problems.
Added:
Modified:
llvm/tools/dsymutil/DebugMap.cpp
llvm/tools/dsymutil/dsymutil.cpp
llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
Removed:
################################################################################
diff --git a/llvm/tools/dsymutil/DebugMap.cpp b/llvm/tools/dsymutil/DebugMap.cpp
index 44780f7c90f7f..a88959ae405c1 100644
--- a/llvm/tools/dsymutil/DebugMap.cpp
+++ b/llvm/tools/dsymutil/DebugMap.cpp
@@ -147,7 +147,7 @@ DebugMap::DebugMap(const Triple &BinaryTriple, StringRef BinaryPath,
ErrorOr<std::vector<std::unique_ptr<DebugMap>>>
DebugMap::parseYAMLDebugMap(BinaryHolder &BinHolder, StringRef InputFile,
StringRef PrependPath, bool Verbose) {
- auto ErrOrFile = MemoryBuffer::getFileOrSTDIN(InputFile);
+ auto ErrOrFile = MemoryBuffer::getFileOrSTDIN(InputFile, /*IsText=*/true);
if (auto Err = ErrOrFile.getError())
return Err;
diff --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp
index f9cee74a2fd50..a416429b5baa8 100644
--- a/llvm/tools/dsymutil/dsymutil.cpp
+++ b/llvm/tools/dsymutil/dsymutil.cpp
@@ -784,7 +784,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
auto ParseAllowDisallowFile =
[&](const std::string &FilePath) -> Expected<StringSet<>> {
- auto BufOrErr = MemoryBuffer::getFile(FilePath);
+ auto BufOrErr = MemoryBuffer::getFile(FilePath, /*IsText=*/true);
if (!BufOrErr)
return make_error<StringError>(
Twine("cannot open allow/disallow file '") + FilePath +
diff --git a/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp b/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
index 33a5a2224e3f9..81afaf2f560d2 100644
--- a/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
+++ b/llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
@@ -610,14 +610,15 @@ static llvm::Error handleFileConversionToGSYM(StringRef Filename,
const std::string &OutFile,
OutputAggregator &Out) {
ErrorOr<std::unique_ptr<MemoryBuffer>> BuffOrErr =
- MemoryBuffer::getFileOrSTDIN(Filename);
+ MemoryBuffer::getFileOrSTDIN(Filename, /*IsText=*/true);
error(Filename, BuffOrErr.getError());
std::unique_ptr<MemoryBuffer> Buffer = std::move(BuffOrErr.get());
std::unique_ptr<MemoryBuffer> SymtabBuffer;
std::unique_ptr<Binary> SymtabBinary;
if (!SymtabFilename.empty()) {
- auto SymtabBufOrErr = MemoryBuffer::getFile(SymtabFilename);
+ auto SymtabBufOrErr =
+ MemoryBuffer::getFile(SymtabFilename, /*IsText=*/true);
if (!SymtabBufOrErr)
return createStringError(SymtabBufOrErr.getError(),
"failed to open symbol table file '%s'",
More information about the llvm-commits
mailing list