[llvm] Fixup"[llvm-ir2vec] Breaking up llvm-ir2vec lib implementation to clean up MIR deps from ir2vec python bindings (#194414)" (PR #198077)

Nishant Sachdeva via llvm-commits llvm-commits at lists.llvm.org
Sat May 16 06:06:55 PDT 2026


https://github.com/nishant-sachdeva updated https://github.com/llvm/llvm-project/pull/198077

>From 25c16c9aaf967869d2ef11016f2f58ce5e887082 Mon Sep 17 00:00:00 2001
From: nishant_sachdeva <nishant.sachdeva at research.iiit.ac.in>
Date: Sat, 16 May 2026 12:56:05 +0530
Subject: [PATCH 1/2] Work Commit - llvm-ir2vec and LLVMMIREmbUtils was missing
 some deps which show up when -DBUILD_SHARED_LIBS=ON. Fixed the Cmakelists.txt
 to reflect accurate dependencies

---
 llvm/tools/llvm-ir2vec/CMakeLists.txt     | 7 +++++++
 llvm/tools/llvm-ir2vec/lib/CMakeLists.txt | 4 ++++
 2 files changed, 11 insertions(+)

diff --git a/llvm/tools/llvm-ir2vec/CMakeLists.txt b/llvm/tools/llvm-ir2vec/CMakeLists.txt
index 64988b1a31e77..298776bc97769 100644
--- a/llvm/tools/llvm-ir2vec/CMakeLists.txt
+++ b/llvm/tools/llvm-ir2vec/CMakeLists.txt
@@ -1,10 +1,17 @@
 set(LLVM_LINK_COMPONENTS
+  # IR processing
+  Analysis
+  Core
+  Support
+
   # IR reading (used by llvm-ir2vec.cpp directly)
   IRReader
 
   # Machine IR components (for -mode=mir)
+  CodeGen
   MIRParser
   MC
+  Target
 
   # Target initialization (required for MIR parsing)
   AllTargetsAsmParsers
diff --git a/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt b/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt
index 38b56b3c1eb97..4a50c21d69d40 100644
--- a/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt
+++ b/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt
@@ -23,6 +23,10 @@ add_llvm_library(LLVMMIREmbUtils STATIC
   intrinsics_gen
 
   LINK_COMPONENTS
+  Analysis
   CodeGen
+  Core   
+  MIRParser
+  Support
   Target
 )

>From 364b29d9523c1e33c74ad90410945ea645c02fdf Mon Sep 17 00:00:00 2001
From: nishant_sachdeva <nishant.sachdeva at research.iiit.ac.in>
Date: Sat, 16 May 2026 14:56:14 +0530
Subject: [PATCH 2/2] Work Commit - Suffices to keep the deps only at
 llvm-ir2vec/cmakelists.txt level

---
 llvm/tools/llvm-ir2vec/CMakeLists.txt     | 1 -
 llvm/tools/llvm-ir2vec/lib/CMakeLists.txt | 4 ----
 2 files changed, 5 deletions(-)

diff --git a/llvm/tools/llvm-ir2vec/CMakeLists.txt b/llvm/tools/llvm-ir2vec/CMakeLists.txt
index 298776bc97769..e3f7a85c7420b 100644
--- a/llvm/tools/llvm-ir2vec/CMakeLists.txt
+++ b/llvm/tools/llvm-ir2vec/CMakeLists.txt
@@ -1,5 +1,4 @@
 set(LLVM_LINK_COMPONENTS
-  # IR processing
   Analysis
   Core
   Support
diff --git a/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt b/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt
index 4a50c21d69d40..38b56b3c1eb97 100644
--- a/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt
+++ b/llvm/tools/llvm-ir2vec/lib/CMakeLists.txt
@@ -23,10 +23,6 @@ add_llvm_library(LLVMMIREmbUtils STATIC
   intrinsics_gen
 
   LINK_COMPONENTS
-  Analysis
   CodeGen
-  Core   
-  MIRParser
-  Support
   Target
 )



More information about the llvm-commits mailing list