[llvm] 96f60ad - [AArch64] Clean-up constrain register check in selectCopy (NFC) (#197168)

via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 06:02:24 PDT 2026


Author: Igor Wodiany
Date: 2026-05-12T14:02:19+01:00
New Revision: 96f60adb34b0a6caf727d395835641fd5147cb48

URL: https://github.com/llvm/llvm-project/commit/96f60adb34b0a6caf727d395835641fd5147cb48
DIFF: https://github.com/llvm/llvm-project/commit/96f60adb34b0a6caf727d395835641fd5147cb48.diff

LOG: [AArch64] Clean-up constrain register check in selectCopy (NFC) (#197168)

This addresses post-commit review from #188781.

Added: 
    

Modified: 
    llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp b/llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
index 5d2b4bc7ac6d3..cf650fd5c4e72 100644
--- a/llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
+++ b/llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
@@ -1056,11 +1056,8 @@ static bool selectCopy(MachineInstr &I, const TargetInstrInfo &TII,
     unsigned SrcSubReg = I.getOperand(1).getSubReg();
     unsigned SubReg;
 
-    if (SrcSubReg) {
-      if (!RBI.constrainGenericRegister(DstReg, *DstRC, MRI))
-        return false;
-      return true;
-    }
+    if (SrcSubReg)
+      return RBI.constrainGenericRegister(DstReg, *DstRC, MRI);
 
     // If the source bank doesn't support a subregister copy small enough,
     // then we first need to copy to the destination bank.


        


More information about the llvm-commits mailing list