[llvm] [InstCombine] Fix one operator precedence (PR #197164)
via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 05:04:12 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Iris Shi (el-ev)
<details>
<summary>Changes</summary>
It is `!(A) || B` while it is intended to be `!(A || B)`.
---
Full diff: https://github.com/llvm/llvm-project/pull/197164.diff
1 Files Affected:
- (modified) llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp (+4-4)
``````````diff
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp b/llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
index dc1a90d486201..f385cc6a7cc83 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
@@ -2326,10 +2326,10 @@ static Instruction *foldICmpUSubSatWithAndForMostSignificantBitCmp(
Value *TrueVal = SI.getTrueValue();
Value *FalseVal = SI.getFalseValue();
- if (!(Pred == ICmpInst::ICMP_EQ &&
- (match(TrueVal, m_Zero()) && match(FalseVal, m_SignMask()))) ||
- (Pred == ICmpInst::ICMP_NE &&
- (match(TrueVal, m_SignMask()) && match(FalseVal, m_Zero()))))
+ if (!((Pred == ICmpInst::ICMP_EQ && match(TrueVal, m_Zero()) &&
+ match(FalseVal, m_SignMask())) ||
+ (Pred == ICmpInst::ICMP_NE && match(TrueVal, m_SignMask()) &&
+ match(FalseVal, m_Zero()))))
return nullptr;
auto *Ty = A->getType();
``````````
</details>
https://github.com/llvm/llvm-project/pull/197164
More information about the llvm-commits
mailing list