[llvm] [Support] Remove unused argument of DataExtractor constructor (NFC) (PR #197121)
via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 01:31:13 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Sergei Barannikov (s-barannikov)
<details>
<summary>Changes</summary>
`AddressSize` parameter is not used by `DataExtractor` and will be removed in the future. See #<!-- -->190519 for more context.
---
Full diff: https://github.com/llvm/llvm-project/pull/197121.diff
4 Files Affected:
- (modified) llvm/include/llvm/Support/ELFAttrParserCompact.h (+1-1)
- (modified) llvm/include/llvm/Support/ELFAttrParserExtended.h (+1-1)
- (modified) llvm/lib/Support/ELFAttrParserCompact.cpp (+1-1)
- (modified) llvm/lib/Support/ELFAttrParserExtended.cpp (+1-1)
``````````diff
diff --git a/llvm/include/llvm/Support/ELFAttrParserCompact.h b/llvm/include/llvm/Support/ELFAttrParserCompact.h
index 9bed36fdacd8b..d7e415331d1c3 100644
--- a/llvm/include/llvm/Support/ELFAttrParserCompact.h
+++ b/llvm/include/llvm/Support/ELFAttrParserCompact.h
@@ -33,7 +33,7 @@ class LLVM_ABI ELFCompactAttrParser : public ELFAttributeParser {
protected:
ScopedPrinter *sw;
TagNameMap tagToStringMap;
- DataExtractor de{ArrayRef<uint8_t>{}, true, 0};
+ DataExtractor de{ArrayRef<uint8_t>{}, true};
DataExtractor::Cursor cursor{0};
void printAttribute(unsigned tag, unsigned value, StringRef valueDesc);
diff --git a/llvm/include/llvm/Support/ELFAttrParserExtended.h b/llvm/include/llvm/Support/ELFAttrParserExtended.h
index d3dc74263d2b0..ee3bf613d688c 100644
--- a/llvm/include/llvm/Support/ELFAttrParserExtended.h
+++ b/llvm/include/llvm/Support/ELFAttrParserExtended.h
@@ -25,7 +25,7 @@ class ScopedPrinter;
class LLVM_ABI ELFExtendedAttrParser : public ELFAttributeParser {
protected:
ScopedPrinter *Sw;
- DataExtractor De{ArrayRef<uint8_t>{}, true, 0};
+ DataExtractor De{ArrayRef<uint8_t>{}, true};
DataExtractor::Cursor Cursor{0};
// Data structure for holding Extended ELF Build Attribute subsection
diff --git a/llvm/lib/Support/ELFAttrParserCompact.cpp b/llvm/lib/Support/ELFAttrParserCompact.cpp
index 14c5533678a75..9665a82374113 100644
--- a/llvm/lib/Support/ELFAttrParserCompact.cpp
+++ b/llvm/lib/Support/ELFAttrParserCompact.cpp
@@ -194,7 +194,7 @@ Error ELFCompactAttrParser::parseSubsection(uint32_t length) {
Error ELFCompactAttrParser::parse(ArrayRef<uint8_t> section,
llvm::endianness endian) {
unsigned sectionNumber = 0;
- de = DataExtractor(section, endian == llvm::endianness::little, 0);
+ de = DataExtractor(section, endian == llvm::endianness::little);
// For early returns, we have more specific errors, consume the Error in
// cursor.
diff --git a/llvm/lib/Support/ELFAttrParserExtended.cpp b/llvm/lib/Support/ELFAttrParserExtended.cpp
index 3d9158a8eac69..33013a360d2f6 100644
--- a/llvm/lib/Support/ELFAttrParserExtended.cpp
+++ b/llvm/lib/Support/ELFAttrParserExtended.cpp
@@ -77,7 +77,7 @@ Error ELFExtendedAttrParser::parse(ArrayRef<uint8_t> Section,
llvm::endianness Endian) {
unsigned SectionNumber = 0;
- De = DataExtractor(Section, Endian == llvm::endianness::little, 0);
+ De = DataExtractor(Section, Endian == llvm::endianness::little);
// Early returns have specific errors. Consume the Error in Cursor.
struct ClearCursorError {
``````````
</details>
https://github.com/llvm/llvm-project/pull/197121
More information about the llvm-commits
mailing list