[lld] [lld][WebAssembly] Improve formatting consistency. NFC (PR #196458)

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 19:05:12 PDT 2026


https://github.com/sbc100 created https://github.com/llvm/llvm-project/pull/196458

None

>From ef5c61d3c23197a1e3ca123a1acd22ba98528cb0 Mon Sep 17 00:00:00 2001
From: Sam Clegg <sbc at chromium.org>
Date: Thu, 7 May 2026 19:03:19 -0700
Subject: [PATCH] [lld][WebAssembly] Improve formatting consistency. NFC

---
 lld/wasm/SymbolTable.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/lld/wasm/SymbolTable.cpp b/lld/wasm/SymbolTable.cpp
index 93d3e5f71a3e5..cda192323f067 100644
--- a/lld/wasm/SymbolTable.cpp
+++ b/lld/wasm/SymbolTable.cpp
@@ -399,9 +399,9 @@ Symbol *SymbolTable::addSharedTag(StringRef name, uint32_t flags,
     return s;
   }
 
-  if (s->isDefined()) {
+  // Shared symbols should never replace locally-defined ones
+  if (s->isDefined())
     return s;
-  }
 
   // undefined existing sym
   const WasmSignature *oldSig = existingTag->signature;
@@ -438,9 +438,8 @@ Symbol *SymbolTable::addSharedFunction(StringRef name, uint32_t flags,
   }
 
   // Shared symbols should never replace locally-defined ones
-  if (s->isDefined()) {
+  if (s->isDefined())
     return s;
-  }
 
   LLVM_DEBUG(dbgs() << "resolving existing undefined symbol: " << s->getName()
                     << "\n");
@@ -477,9 +476,8 @@ Symbol *SymbolTable::addSharedData(StringRef name, uint32_t flags,
   }
 
   // Shared symbols should never replace locally-defined ones
-  if (s->isDefined()) {
+  if (s->isDefined())
     return s;
-  }
 
   checkDataType(s, file);
   replaceSymbol<SharedData>(s, name, flags, file);



More information about the llvm-commits mailing list