[llvm] [DirectX] Verify root signature version before parsing metadata (PR #196667)
via llvm-commits
llvm-commits at lists.llvm.org
Fri May 8 16:46:58 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Frontend/HLSL/RootSignatureMetadata.cpp llvm/lib/Target/DirectX/DXILRootSignature.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/DirectX/DXILRootSignature.cpp b/llvm/lib/Target/DirectX/DXILRootSignature.cpp
index 2b92e77f1..ebe330a15 100644
--- a/llvm/lib/Target/DirectX/DXILRootSignature.cpp
+++ b/llvm/lib/Target/DirectX/DXILRootSignature.cpp
@@ -129,9 +129,10 @@ analyzeModule(Module &M) {
reportError(Ctx, "Invalid RSDefNode value, expected constant int");
continue;
}
-
- if(hlsl::rootsig::verifyVersion(*V) == false) {
- reportError(Ctx, "Invalid Root Signature Version: " + Twine(*V) + ". Metadata will not be processed.");
+
+ if (hlsl::rootsig::verifyVersion(*V) == false) {
+ reportError(Ctx, "Invalid Root Signature Version: " + Twine(*V) +
+ ". Metadata will not be processed.");
continue;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/196667
More information about the llvm-commits
mailing list