[llvm] [z/OS] Add z/OS archive reading support (PR #187110)

[James Henderson via llvm-commits]

================
@@ -437,22 +433,22 @@ void ZOSArchiveMemberHeader::setMemberHeaderStrings(Error *Err, uint64_t Size) {
   RawMemberName.assign(RawNameRef);
 
   // Set MemberName.
-  if (RawNameRef.starts_with("#1/")) {
+  if (StringRef(RawNameRef).starts_with("#1/")) {
     Expected<StringRef> NameOrErr = ArchiveMemberHeader::getName(Size);
     if (!NameOrErr) {
       *Err = NameOrErr.takeError();
       return;
     }
     StringRef Name = NameOrErr.get();
-    Dst.clear();
-    ConverterEBCDIC::convertToUTF8(Name, Dst);
-    MemberName.append(Dst.str());
+    SmallString<64> ConvertedName;
+    ConverterEBCDIC::convertToUTF8(Name, ConvertedName);
+    MemberName.assign(ConvertedName.str());
----------------
jh7370 wrote:

`MemberName = std::string(ConvertedName);` should do the job, right?

Assuming so, I think this is clearer than `assign` + `str`.

https://github.com/llvm/llvm-project/pull/187110