[llvm] [z/OS] Add z/OS archive reading support (PR #187110)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu May 7 01:21:01 PDT 2026
================
@@ -368,6 +377,123 @@ Expected<uint64_t> BigArchiveMemberHeader::getSize() const {
return *SizeOrErr + alignTo(*NameLenOrErr, 2);
}
+template <std::size_t N>
+StringRef ebcdicFieldToASCII(const char (&Field)[N],
----------------
jh7370 wrote:
Would it make more sense to simply return `std::string` from here and convert within the function and return, rather than jumping through the hoop involving `assign` that you do repeatedly?
It would also avoid the slightly weird need to pass in storage for the converter to use, even though the function returns a value with the result in, and therefore leading to two things at the call site that can be used to access the value.
https://github.com/llvm/llvm-project/pull/187110
More information about the llvm-commits
mailing list