[llvm] [gn] Fix a benign bug in write_cmake_config.py (PR #196043)

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 03:55:39 PDT 2026


https://github.com/nico created https://github.com/llvm/llvm-project/pull/196043

A local read() function was ignoring its parameter and was instead always using the value that was passed in as parameter anyways.

No actual behavior change.

>From 4075dbc830bfb06e2f1c199210a4467a57b73b23 Mon Sep 17 00:00:00 2001
From: Nico Weber <thakis at chromium.org>
Date: Tue, 5 May 2026 21:06:42 -0400
Subject: [PATCH] [gn] Fix a benign bug in write_cmake_config.py

A local read() function was ignoring its parameter and was instead
always using the value that was passed in as parameter anyways.

No actual behavior change.
---
 llvm/utils/gn/build/write_cmake_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/gn/build/write_cmake_config.py b/llvm/utils/gn/build/write_cmake_config.py
index a14df6b2cdeab..6299372ff83ce 100755
--- a/llvm/utils/gn/build/write_cmake_config.py
+++ b/llvm/utils/gn/build/write_cmake_config.py
@@ -109,7 +109,7 @@ def repl(m):
         return 1
 
     def read(filename):
-        with open(args.output) as f:
+        with open(filename) as f:
             return f.read()
 
     if not os.path.exists(args.output) or read(args.output) != output:



More information about the llvm-commits mailing list