[llvm] [DirectX][ObjectYAML] Add ILDB program part support (PR #189685)

Vladislav Dzhidzhoev via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 03:50:15 PDT 2026


================
@@ -11,9 +11,9 @@ Header:
   Version:
     Major:           1
     Minor:           0
-  FileSize:        3548
-  PartCount:       7
-  PartOffsets:     [ 60, 76, 92, 108, 236, 1932, 1960 ]
+  FileSize:        2040
----------------
dzhidzhoev wrote:

> I don't necessarily disagree with the logic here, but I don't see anything in this patch that I would expect to cause this to change. Do you know why the test was passing before if it's wrong?

The DXContainer loader and writer don’t check whether the actual size of the DXContainer exactly matches FileSize. The test would fail if the FileSize value were too small to fit the file content, but DXContainerEmitter accepts a FileSize that is larger than the actual size (see `DXContainerWriter::validateSize()`).

There’s no strict need to update the value of this field in this PR. However, I found the mismatch confusing when adding a new part to the test. I assume it will be easier to maintain the test if the FileSize is accurate.

https://github.com/llvm/llvm-project/pull/189685


More information about the llvm-commits mailing list