[llvm] [GitHub] Skip PR subscriber comments for empty teams (PR #195920)
Daniil Dudkin via llvm-commits
llvm-commits at lists.llvm.org
Tue May 5 12:48:01 PDT 2026
https://github.com/unterumarmung created https://github.com/llvm/llvm-project/pull/195920
PR subscriber labels can map to teams that currently have no members. For example, `@llvm/pr-subscribers-clang-tools-extra` exists but has no subscribers, so new PRs touching clang-tools-extra get a bot comment that does not notify anyone.
Check the subscriber team membership before producing or updating the PR subscriber summary comment, and treat empty teams as a successful no-op.
>From b06adc68761fbe27360f377c44b62028bf45962b Mon Sep 17 00:00:00 2001
From: Daniil Dudkin <unterumarmung at yandex.ru>
Date: Tue, 5 May 2026 22:44:20 +0300
Subject: [PATCH] [GitHub] Skip PR subscriber comments for empty teams
PR subscriber labels can map to teams that currently have no members. For example, @llvm/pr-subscribers-clang-tools-extra exists but has no subscribers, so new PRs touching clang-tools-extra get a bot comment that does not notify anyone.
Check the subscriber team membership before producing or updating the PR subscriber summary comment, and treat empty teams as a successful no-op.
---
llvm/utils/git/github-automation.py | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 6cd5953eba19c..1aa8b3e59f2b3 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -45,6 +45,10 @@ def _get_current_team(team_name, teams) -> Optional[github.Team.Team]:
return None
+def _team_has_members(team: github.Team.Team) -> bool:
+ return team.get_members().totalCount > 0
+
+
def escape_description(str):
# If the description of an issue/pull request is empty, the Github API
# library returns None instead of an empty string. Handle this here to
@@ -155,6 +159,9 @@ def run(self) -> bool:
if not team:
print(f"couldn't find team named {self.team_name}")
return False
+ if not _team_has_members(team):
+ print(f"team {team.slug} has no members, skip subscribers")
+ return True
# GitHub limits comments to 65,536 characters, let's limit the diff
# and the file list to 20kB each.
More information about the llvm-commits
mailing list