[llvm] [InstCombine][NFC] Use CreateAssumption instead of CreateCall (PR #195862)

[Nikita Popov via llvm-commits]

================
@@ -3627,21 +3627,16 @@ Instruction *InstCombinerImpl::visitCallInst(CallInst &CI) {
     // Canonicalize assume(a && b) -> assume(a); assume(b);
     // Note: New assumption intrinsics created here are registered by
     // the InstCombineIRInserter object.
-    FunctionType *AssumeIntrinsicTy = II->getFunctionType();
-    Value *AssumeIntrinsic = II->getCalledOperand();
-    Value *A, *B;
-    if (match(IIOperand, m_LogicalAnd(m_Value(A), m_Value(B)))) {
-      Builder.CreateCall(AssumeIntrinsicTy, AssumeIntrinsic, A, OpBundles,
-                         II->getName());
-      Builder.CreateCall(AssumeIntrinsicTy, AssumeIntrinsic, B, II->getName());
+    if (Value *A, *B; match(IIOperand, m_LogicalAnd(m_Value(A), m_Value(B)))) {
----------------
nikic wrote:

Please keep the declarations of A/B outside the if, this is non-idiomatic.

https://github.com/llvm/llvm-project/pull/195862