[llvm] [lit] Use dbg instead of note for tool detection (PR #193662)

[Henrik G. Olsson via llvm-commits]

hnrklssn wrote:

> Then CI should run LIT_OPTS=-debug

I think `--debug` should be for things that are used when debugging lit itself, and not something CI should be expected to use.

> Information is unlikely useful for a typical test run.

This is true for all uses of `note` in lit, but changing all of them to use `dbg` instead does not seem useful, as it would effectively remove one diagnostic level. I share your frustration with lit's default verbosity however, which is why I added the `--diagnostic-level` option a while back. I personally set `--diagnostic-level=error` by default on my dev machine, but `warning` is also an option if you don't find the warnings annoying.

Now, is it a bit weird that the default diagnostic level we ship isn't what most people probably should be using? Yes, and I would support changing it, but that would require some discussion with the rest of the community first.

https://github.com/llvm/llvm-project/pull/193662