[llvm] [offload] record-replay: only check user-provided grid sizes (PR #195190)

[via llvm-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-offload

Author: Robert Imschweiler (ro-i)

<details>
<summary>Changes</summary>

The plugins sometimes change what the user provided for num_threads or num_teams and choose different values for the actual launch. This should not lead to errors in the replay mechanism. The original clause values should only be checked if the user specified new values for replay explicitly.

---
Full diff: https://github.com/llvm/llvm-project/pull/195190.diff


1 Files Affected:

- (modified) offload/tools/kernelreplay/llvm-omp-kernel-replay.cpp (+6-3) 


``````````diff
diff --git a/offload/tools/kernelreplay/llvm-omp-kernel-replay.cpp b/offload/tools/kernelreplay/llvm-omp-kernel-replay.cpp
index a5bda7a0f0444..dc6b2f532f383 100644
--- a/offload/tools/kernelreplay/llvm-omp-kernel-replay.cpp
+++ b/offload/tools/kernelreplay/llvm-omp-kernel-replay.cpp
@@ -211,11 +211,14 @@ Error replayKernel() {
   if (TeamsLimits.size() != 2 || ThreadsLimits.size() != 2)
     return createErr("TeamsLimits and ThreadsLimits must have a min and max");
 
-  // If the limits were specified, verify the selected values are valid.
-  if (TeamsLimits[0] > 0 &&
+  // If the limits were specified and the user is overriding the recorded
+  // launch geometry, verify the selected values are within bounds. When no
+  // override is given we replay with the values that have been actually used by
+  // runtime, which may have chosen to clamp or round teams or threads.
+  if (NumTeamsOpt > 0 && TeamsLimits[0] > 0 &&
       (NumTeams < TeamsLimits[0] || NumTeams > TeamsLimits[1]))
     return createErr("number of teams is out of the allowed limits");
-  if (ThreadsLimits[0] > 0 &&
+  if (NumThreadsOpt > 0 && ThreadsLimits[0] > 0 &&
       (NumThreads < ThreadsLimits[0] || NumThreads > ThreadsLimits[1]))
     return createErr("number of threads is out of the allowed limits");
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/195190