[llvm] [TextAPI] Add option to filter out unsupported/unknown/invalid targets (PR #195161)

Cyndy Ishida via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 18:06:56 PDT 2026


================
@@ -313,6 +314,12 @@ template <> struct MappingTraits<UndefinedSection> {
 template <> struct MappingTraits<SymbolSection> {
   static void mapping(IO &IO, SymbolSection &Section) {
     IO.mapRequired("targets", Section.Targets);
+    // With SkipUnknownTriples, ScalarTraits of Target accepts unknown
+    // arch/platform scalars without erroring, leaving invalid Targets in the
+    // vector. Drop them so downstream code only sees valid Targets.
----------------
cyndyishida wrote:

I don't see an obvious way to control what gets assigned in `Section.Targets`. Are you suggesting wrapping/replacing the `erase_if` in a helper function that gets called in the same places? I don't see how that helps much.

https://github.com/llvm/llvm-project/pull/195161


More information about the llvm-commits mailing list