[llvm] [X86] Compute `CTLZ` using fp math for `v4i32` on SSE2 targets (PR #190930)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 30 04:11:55 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- llvm/include/llvm/CodeGen/TargetLowering.h llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp llvm/lib/Target/X86/X86ISelLowering.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
index b54bcc9a6..d629efe6b 100644
--- a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
@@ -9901,7 +9901,8 @@ SDValue TargetLowering::expandCTLZWithFP(SDNode *Node,
EVT HalfFloatVT = HalfVT.changeVectorElementType(*DAG.getContext(), MVT::f64);
EVT HalfFloatBitsVT = HalfFloatVT.changeVectorElementTypeToInteger();
- const fltSemantics &Sem = HalfFloatVT.getVectorElementType().getFltSemantics();
+ const fltSemantics &Sem =
+ HalfFloatVT.getVectorElementType().getFltSemantics();
unsigned BitWidth = EltVT.getSizeInBits();
unsigned MantissaBits = APFloat::semanticsPrecision(Sem);
unsigned ExponentBias = APFloat::semanticsMaxExponent(Sem);
@@ -9909,7 +9910,8 @@ SDValue TargetLowering::expandCTLZWithFP(SDNode *Node,
auto ComputeExp = [&](SDValue Half) {
SDValue Float = DAG.getNode(ISD::UINT_TO_FP, dl, HalfFloatVT, Half);
SDValue Bits = DAG.getBitcast(HalfFloatBitsVT, Float);
- SDValue Exp = DAG.getNode(ISD::SRL, dl, HalfFloatBitsVT, Bits,
+ SDValue Exp = DAG.getNode(
+ ISD::SRL, dl, HalfFloatBitsVT, Bits,
DAG.getShiftAmountConstant(MantissaBits - 1, HalfFloatBitsVT, dl));
return DAG.getNode(ISD::TRUNCATE, dl, HalfVT, Exp);
};
@@ -9917,9 +9919,11 @@ SDValue TargetLowering::expandCTLZWithFP(SDNode *Node,
SDValue ExpTruncLo = ComputeExp(DAG.getExtractSubvector(dl, HalfVT, Op, 0));
SDValue ExpTruncHi = ComputeExp(
DAG.getExtractSubvector(dl, HalfVT, Op, VT.getVectorNumElements() / 2));
- SDValue Exp = DAG.getNode(ISD::CONCAT_VECTORS, dl, VT, ExpTruncLo, ExpTruncHi);
- SDValue NonZeroRes = DAG.getNode(ISD::SUB, dl, VT,
- DAG.getConstant(BitWidth - 1 + ExponentBias, dl, VT), Exp);
+ SDValue Exp =
+ DAG.getNode(ISD::CONCAT_VECTORS, dl, VT, ExpTruncLo, ExpTruncHi);
+ SDValue NonZeroRes =
+ DAG.getNode(ISD::SUB, dl, VT,
+ DAG.getConstant(BitWidth - 1 + ExponentBias, dl, VT), Exp);
// Skip Op == 0 case for CTLZ_ZERO_UNDEF
if (Node->getOpcode() == ISD::CTLZ_ZERO_UNDEF)
``````````
</details>
https://github.com/llvm/llvm-project/pull/190930
More information about the llvm-commits
mailing list