[llvm] [CodeGen] Port mir-debugify to new pass manager (PR #193201)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 29 13:52:00 PDT 2026
juanvazquez wrote:
> > I did think that `applyDebugifyMetadata` was exposed to do not reuse `NewPMDebugifyPass`, but I'm not familiar with the code so I could have misinterpreted totally, sorry about that.
> > What you mean is that I should modify "NewPMDebugifyPass" to take care both of "debugify" and "mir-debugify" and remove the `DebugifyMachineModulePass` introduced in this PR?
> > Really appreciate the feedback.
>
> You can, let `NewPMDebugifyPass` and `DebugifyMachineModulePass` share the common base pass `ApplyToMF` only in `DebugifyMachineModulePass`.
>
> https://github.com/llvm/llvm-project/blob/c1e78ed3d603923a077899b32341647904d9007f/llvm/lib/Transforms/Utils/Debugify.cpp#L1064-L1076
@paperchalice I've modified the PR to reuse `NewPMDebugifyPass` then. I've added a different commit so it's easy for me to revert if needed. Kindly let me know if that is what you had in mind. On my side happy to continue with this route if it's the expected way.
https://github.com/llvm/llvm-project/pull/193201
More information about the llvm-commits
mailing list