[llvm] [ObjCopy] Reject compress-debug-sections for non-ELF (PR #191314)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 00:22:43 PDT 2026


jh7370 wrote:

> > Thanks, basically looks good. I've added @mstorsjo, in case he wants to take a quick look.
> > I noticed that in #193965, @mstorsjo used `Common.compressSections` instead of `Common.CompressionType`. Could you take a look and see what the functional difference is between the two, i.e. when are they used/not used and do the two checks have the same overall result?
> 
> `Common.compressSections` is used for the `--compress-sections` option (which also is only implemented for ELF), while `Common.CompressionType` is used for `--compress-debug-sections`.

Thanks, so we need to check `Common.compressSections` too in all the formats. @nataliakokoromyti, do you want to add that, or shall we just accept @mstorsjo's version, which already includes it?

https://github.com/llvm/llvm-project/pull/191314


More information about the llvm-commits mailing list