[llvm] [AMDGPU] Add `.amdgpu.info` section for per-function metadata (PR #192384)
Paul Kirth via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 09:25:39 PDT 2026
https://github.com/ilovepi commented:
I think your use of the call graph section is acceptable, though depending on how things evolve there may need to be adjustments down the line. My team, and some other folks in the embedded community have started discussing supporting more features in the linker, like doing layout based on the call graph, and IMO the AMDGPU use is different enough that we'd probably want something slightly different. That's all still being discussed, so I don't think its anything that should block work ready to land now.
I do have some reservations about the ABI encoding schema, but I'm not the AMDGPU code owner, and since I don't work on AMDGPU, I can't comment on its suitability or anything other than the regular C++/testing comments anyone in LLVM can make.
So, LGTM from me on the callgraph and overall C++/tests. I think you need an owner to weigh in on the rest.
https://github.com/llvm/llvm-project/pull/192384
More information about the llvm-commits
mailing list