[clang] [llvm] Compute GUIDs once and store in metadata (PR #184065)

[Owen Rodley via llvm-commits]

================
@@ -599,8 +600,8 @@ class GlobalValueSummary {
   bool wasPromoted() const { return Flags.Promoted; }
 
   void promote() {
-    assert(GlobalValue::isLocalLinkage(linkage()) &&
-           "unexpected (re-)promotion of non-local symbol");
+    assert(!GlobalValue::isExternalLinkage(linkage()) &&
----------------
orodley wrote:

Leftover from Mircea's original prototype of PR 181946. Reverted.

https://github.com/llvm/llvm-project/pull/184065