[llvm] [DAG] - computeKnownFPClass - ISD::FMAXIMUM/ISD::FMINIMUM + ISD::FMAXIMUMNUM/ISD::FMINIMUMNUM (PR #190465)

Kartik Ohlan via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 19 20:01:47 PDT 2026


Ko496-glitch wrote:

@arsenm i have a question about your comment on inlining the lambda, so given what Simon suggested for the change(his case statement) that would force me to write a lambda or a static function which would be like 

```
static KnownFPClass GetMinMaxKnownFPClass(const SelectionDAG &DAG,
                                          SDValue LHS, SDValue RHS,
                                          KnownFPClass::MinMaxKind Kind,
                                          const APInt &DemandedElts,
                                          FPClassTest InterestedClasses,
                                          unsigned Depth)
```
my only confusion, from you pov is there any other otherwise the changes will collide with each other no ? I have both version on commits for you to take a look :) 

also currently this has test case for AMD - GPU, please let me know if i should add test cases for X86  etc 

https://github.com/llvm/llvm-project/pull/190465


More information about the llvm-commits mailing list