https://github.com/teresajohnson commented: Couple suggestions below. Also, please don't rebase while reviewing is in progress (https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes). https://github.com/llvm/llvm-project/pull/188074