[llvm] [DAG] - computeKnownFPClass - ISD::FMAXIMUM/ISD::FMINIMUM + ISD::FMAXIMUMNUM/ISD::FMINIMUMNUM (PR #190465)

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 19 02:14:02 PDT 2026


RKSimon wrote:

> @RKSimon i am kind of confuse because earlier comments on commits were about adding the 'GetMinMaxKnownFPClass(SDValue LHS, SDValue RHS, KnownFPClass::MinMaxKind) ?

You're missing the point - the suggestion was to avoid repeated switches, so something like:
```
  case ISD::FMAXNUM: {
    Known = GetMinMaxKnownFPClass(Op.getOperand(0), Op.getOperand(1),
                                  KnownFPClass::MinMaxKind::maxnum);
    break;
  }
  case ISD::FMINNUM: {
    Known = GetMinMaxKnownFPClass(Op.getOperand(0), Op.getOperand(1),
                                  KnownFPClass::MinMaxKind::minnum);
    break;
  }
  case ISD::FMAXIMUM: {
    Known = GetMinMaxKnownFPClass(Op.getOperand(0), Op.getOperand(1),
                                  KnownFPClass::MinMaxKind::maximum);
    break;
  }
  case ISD::FMINIMUM: {
    Known = GetMinMaxKnownFPClass(Op.getOperand(0), Op.getOperand(1),
                                  KnownFPClass::MinMaxKind::minimum);
    break;
  }
  case ISD::FMAXIMUMNUM: {
    Known = GetMinMaxKnownFPClass(Op.getOperand(0), Op.getOperand(1),
                                  KnownFPClass::MinMaxKind::maximumnum);
    break;
  }
  case ISD::FMINIMUMNUM: {
    Known = GetMinMaxKnownFPClass(Op.getOperand(0), Op.getOperand(1),
                                  KnownFPClass::MinMaxKind::minimumnum);
    break;
  }
```

https://github.com/llvm/llvm-project/pull/190465


More information about the llvm-commits mailing list