[llvm] bf10fc8 - [lit] Fix tests when run via symlinks (#192530)

via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 12:49:02 PDT 2026


Author: Keith Smiley
Date: 2026-04-17T12:48:57-07:00
New Revision: bf10fc870e0db55a81db1d0da768011370113101

URL: https://github.com/llvm/llvm-project/commit/bf10fc870e0db55a81db1d0da768011370113101
DIFF: https://github.com/llvm/llvm-project/commit/bf10fc870e0db55a81db1d0da768011370113101.diff

LOG: [lit] Fix tests when run via symlinks (#192530)

If the path to Inputs/filter-failed was a symlink, it would copy the
symlinks, and then edit the same files, leading to flaky failures if the
tests ran in parallel.

Added: 
    

Modified: 
    llvm/utils/lit/tests/filter-failed-delete.py
    llvm/utils/lit/tests/filter-failed-rerun.py
    llvm/utils/lit/tests/filter-failed.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/tests/filter-failed-delete.py b/llvm/utils/lit/tests/filter-failed-delete.py
index 68bb840425ea3..9f7811e0a941b 100644
--- a/llvm/utils/lit/tests/filter-failed-delete.py
+++ b/llvm/utils/lit/tests/filter-failed-delete.py
@@ -2,7 +2,7 @@
 # before running with --filter-failed.
 
 # RUN: rm -rf %t
-# RUN: cp -r %{inputs}%{fs-sep}filter-failed %t
+# RUN: cp -rL %{inputs}%{fs-sep}filter-failed %t
 #
 # RUN: not %{lit} %t | FileCheck %s --check-prefix=CHECK-FIRST
 #

diff  --git a/llvm/utils/lit/tests/filter-failed-rerun.py b/llvm/utils/lit/tests/filter-failed-rerun.py
index 1513f638371f7..0a4175bf5e264 100644
--- a/llvm/utils/lit/tests/filter-failed-rerun.py
+++ b/llvm/utils/lit/tests/filter-failed-rerun.py
@@ -2,7 +2,7 @@
 # since the last time --filter-failed was run.
 
 # RUN: rm -rf %t
-# RUN: cp -r %{inputs}%{fs-sep}filter-failed %t
+# RUN: cp -rL %{inputs}%{fs-sep}filter-failed %t
 #
 # RUN: not %{lit} %t | FileCheck %s --check-prefix=CHECK-FIRST
 #

diff  --git a/llvm/utils/lit/tests/filter-failed.py b/llvm/utils/lit/tests/filter-failed.py
index 3c1c6fe010077..261418dcc711e 100644
--- a/llvm/utils/lit/tests/filter-failed.py
+++ b/llvm/utils/lit/tests/filter-failed.py
@@ -1,7 +1,7 @@
 # Checks that --filter-failed only runs tests that previously failed.
 
 # RUN: rm -rf %t
-# RUN: cp -r %{inputs}%{fs-sep}filter-failed %t
+# RUN: cp -rL %{inputs}%{fs-sep}filter-failed %t
 #
 # RUN: not %{lit} %t
 #


        


More information about the llvm-commits mailing list