[lld] [lld][MachO] Preserve __eh_frame ordering during BP section sorting (PR #191412)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3132 tests passed
* 61 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### lld
<details>
<summary>lld.MachO/eh-frame-ordering.s</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 9
c:\_work\llvm-project\llvm-project\build\bin\llvm-mc.exe -filetype=obj -emit-compact-unwind-non-canonical=true -triple=x86_64-apple-macos10.15 C:\_work\llvm-project\llvm-project\lld\test\MachO\eh-frame-ordering.s -o C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64.o
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\llvm-mc.exe' -filetype=obj -emit-compact-unwind-non-canonical=true -triple=x86_64-apple-macos10.15 'C:\_work\llvm-project\llvm-project\lld\test\MachO\eh-frame-ordering.s' -o 'C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64.o'
# note: command had no output on stdout or stderr
# RUN: at line 10
ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot C:\_work\llvm-project\llvm-project\lld\test\MachO\Inputs\MacOSX.sdk -lSystem -fatal_warnings -lSystem -lc++ C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64.o -o C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64 --bp-compression-sort=both
# executed command: ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot 'C:\_work\llvm-project\llvm-project\lld\test\MachO\Inputs\MacOSX.sdk' -lSystem -fatal_warnings -lSystem -lc++ 'C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64.o' -o 'C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64' --bp-compression-sort=both
# note: command had no output on stdout or stderr
# RUN: at line 11
c:\_work\llvm-project\llvm-project\build\bin\llvm-objdump.exe --dwarf=frames C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\lld\test\MachO\eh-frame-ordering.s --implicit-check-not=error --implicit-check-not=warning
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\llvm-objdump.exe' --dwarf=frames 'C:\_work\llvm-project\llvm-project\build\tools\lld\test\MachO\Output\eh-frame-ordering.s.tmp-x86_64'
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\lld\test\MachO\eh-frame-ordering.s' --implicit-check-not=error --implicit-check-not=warning
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\lld\test\MachO\eh-frame-ordering.s:25:14: error: CHECK-NOT: excluded string found in input
# | # CHECK-NOT: CIE
# |              ^
# | <stdin>:48:28: note: found here
# | 00000070 0000001c 00000000 CIE
# |                            ^~~
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\lld\test\MachO\eh-frame-ordering.s
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |         .
# |         .
# |         .
# |        43:  DW_CFA_nop: 
# |        44:  DW_CFA_nop: 
# |        45:  
# |        46:  0x100000484: CFA=reg7+16: reg16=[CFA-8] 
# |        47:  
# |        48: 00000070 0000001c 00000000 CIE 
# | not:25                                !~~  error: no match expected
# |        49:  Format: DWARF32 
# |        50:  Version: 1 
# |        51:  Augmentation: "zPLR" 
# |        52:  Code alignment factor: 1 
# |        53:  Data alignment factor: -8 
# |         .
# |         .
# |         .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/191412