[llvm] [llvm][DebugInfo] Use formatv in LVCompare (PR #192001)

Konrad Kleine via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 05:35:49 PDT 2026


https://github.com/kwk updated https://github.com/llvm/llvm-project/pull/192001

>From 5b2df83838f104b8e10e6b3f181ae108a6e81cdf Mon Sep 17 00:00:00 2001
From: Konrad Kleine <kkleine at redhat.com>
Date: Mon, 13 Apr 2026 20:20:30 +0000
Subject: [PATCH 1/3] [llvm][DebugInfo] formatv in LVCompare

This relates to #35980.
---
 llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp b/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
index 3cb2662f2f313..65e28fd27e1fa 100644
--- a/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
@@ -405,10 +405,10 @@ void LVCompare::printSummary() const {
   auto PrintSeparator = [&]() { OS << Separator << "\n"; };
   auto PrintHeadingRow = [&](const char *T, const char *U, const char *V,
                              const char *W) {
-    OS << format("%-9s%9s  %9s  %9s\n", T, U, V, W);
+    OS << formatv("{0, -9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);
   };
   auto PrintDataRow = [&](const char *T, unsigned U, unsigned V, unsigned W) {
-    OS << format("%-9s%9d  %9d  %9d\n", T, U, V, W);
+    OS << formatv("{0, -9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);
   };
 
   OS << "\n";

>From d4116bfec19f5c68489021f3d3c896b93b518ad4 Mon Sep 17 00:00:00 2001
From: Konrad Kleine <kkleine at redhat.com>
Date: Wed, 15 Apr 2026 07:07:02 +0000
Subject: [PATCH 2/3] Use default separator

In earlier PRs we decided to not specify the default separator
explicitly again.
---
 llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp b/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
index 65e28fd27e1fa..b001161f84758 100644
--- a/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
@@ -408,7 +408,7 @@ void LVCompare::printSummary() const {
     OS << formatv("{0, -9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);
   };
   auto PrintDataRow = [&](const char *T, unsigned U, unsigned V, unsigned W) {
-    OS << formatv("{0, -9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);
+    OS << formatv("{0,-9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);
   };
 
   OS << "\n";

>From 9d7a67c436e62401aef75cff8c43f4c805915a06 Mon Sep 17 00:00:00 2001
From: Konrad Kleine <kkleine at redhat.com>
Date: Wed, 15 Apr 2026 12:35:25 +0000
Subject: [PATCH 3/3] Fixup

---
 llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp b/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
index b001161f84758..de43c2d59e896 100644
--- a/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp
@@ -405,7 +405,7 @@ void LVCompare::printSummary() const {
   auto PrintSeparator = [&]() { OS << Separator << "\n"; };
   auto PrintHeadingRow = [&](const char *T, const char *U, const char *V,
                              const char *W) {
-    OS << formatv("{0, -9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);
+    OS << formatv("{0,-9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);
   };
   auto PrintDataRow = [&](const char *T, unsigned U, unsigned V, unsigned W) {
     OS << formatv("{0,-9}{1,9}  {2,9}  {3,9}\n", T, U, V, W);



More information about the llvm-commits mailing list